Review Request: Misc minor fixes in KRunner.

[David Edmundson]

> On April 6, 2012, 10:03 p.m., Lamarque Vieira Souza wrote:
> > plasma/generic/dataengines/activities/activityengine.cpp, line 69
> > <http://git.reviewboard.kde.org/r/104431/diff/1/?file=55063#file55063line69>
> >
> >     If this patch is meant to master branch you must not comment this line.

Urgh, my fault. 
I put them in so that I could compile. Only as working directory changes, I had made sure not to commit them. Then I managed to include them in the diff like an idiot.


> On April 6, 2012, 10:03 p.m., Lamarque Vieira Souza wrote:
> > plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop, line 2
> > <http://git.reviewboard.kde.org/r/104431/diff/1/?file=55065#file55065line2>
> >
> >     You are changing translatable strings here, so this patch must go to kde-workspace master only. Some lines above you commented the activity encrypted calls. I thought you did that because this patch is meant to KDE/4.8 and encrypted activities is a new feature that has not (and will never be) backported to KDE/4.8. Please uncomment the lines about encrypted activities.

Only intend for master.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104431/#review12204
-----------------------------------------------------------


On March 28, 2012, 1:56 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104431/
> -----------------------------------------------------------
> 
> (Updated March 28, 2012, 1:56 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> * Remove "runner" from "Nepomuk Desktop Search Runner" as the runner is implied from the context and to bring consistency.
> * Add correct icon for activities runner
> * Use correct case in description of "places" runner.
> * Use correct case in Webshorts runner description
> * Match top and bottom margin sizes. This updates a bodge that removed 2 pixels from the top margin to only use 1.
> * Reword "Available Features" to "Available Plugins" for consistency
> * Make the krunner config dialog appear to load slightly faster by loading the list of plugins after we've shown the dialog.
> * Remove undefined (and unused) private method.
> 
> 
> Diffs
> -----
> 
>   krunner/configdialog.h a9c353a 
>   krunner/configdialog.cpp 80485ca 
>   krunner/krunnerdialog.cpp 007887f 
>   plasma/generic/dataengines/activities/activityengine.cpp cbbc559 
>   plasma/generic/runners/activities/plasma-runner-activityrunner.desktop 853c680 
>   plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop 0319463 
>   plasma/generic/runners/places/plasma-runner-places.desktop b82fa14 
>   plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop f234b4f 
> 
> Diff: http://git.reviewboard.kde.org/r/104431/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120406/356218cf/attachment.html>