<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104431/">http://git.reviewboard.kde.org/r/104431/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 6th, 2012, 10:03 p.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104431/diff/1/?file=55063#file55063line69" style="color: black; font-weight: bold; text-decoration: underline;">plasma/generic/dataengines/activities/activityengine.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ActivityEngine::insertActivity(const QString &id)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">69</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setData</span><span class="p">(</span><span class="n">id</span><span class="p">,</span> <span class="s">"Encrypted"</span><span class="p">,</span> <span class="n">activity</span><span class="o">-></span><span class="n">isEncrypted</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">69</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1"><span class="hl">// </span> setData(id, "Encrypted", activity->isEncrypted());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If this patch is meant to master branch you must not comment this line.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Urgh, my fault.
I put them in so that I could compile. Only as working directory changes, I had made sure not to commit them. Then I managed to include them in the diff like an idiot.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 6th, 2012, 10:03 p.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/104431/diff/1/?file=55065#file55065line2" style="color: black; font-weight: bold; text-decoration: underline;">plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Name=Nepomuk Desktop Search<span class="hl"> Runner</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Name=Nepomuk Desktop Search</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are changing translatable strings here, so this patch must go to kde-workspace master only. Some lines above you commented the activity encrypted calls. I thought you did that because this patch is meant to KDE/4.8 and encrypted activities is a new feature that has not (and will never be) backported to KDE/4.8. Please uncomment the lines about encrypted activities.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only intend for master.</pre>
<br />
<p>- David</p>
<br />
<p>On March 28th, 2012, 1:56 a.m., David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 28, 2012, 1:56 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Remove "runner" from "Nepomuk Desktop Search Runner" as the runner is implied from the context and to bring consistency.
* Add correct icon for activities runner
* Use correct case in description of "places" runner.
* Use correct case in Webshorts runner description
* Match top and bottom margin sizes. This updates a bodge that removed 2 pixels from the top margin to only use 1.
* Reword "Available Features" to "Available Plugins" for consistency
* Make the krunner config dialog appear to load slightly faster by loading the list of plugins after we've shown the dialog.
* Remove undefined (and unused) private method.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>krunner/configdialog.h <span style="color: grey">(a9c353a)</span></li>
<li>krunner/configdialog.cpp <span style="color: grey">(80485ca)</span></li>
<li>krunner/krunnerdialog.cpp <span style="color: grey">(007887f)</span></li>
<li>plasma/generic/dataengines/activities/activityengine.cpp <span style="color: grey">(cbbc559)</span></li>
<li>plasma/generic/runners/activities/plasma-runner-activityrunner.desktop <span style="color: grey">(853c680)</span></li>
<li>plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop <span style="color: grey">(0319463)</span></li>
<li>plasma/generic/runners/places/plasma-runner-places.desktop <span style="color: grey">(b82fa14)</span></li>
<li>plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop <span style="color: grey">(f234b4f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104431/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>