Review Request: Misc minor fixes in KRunner.

David Edmundson kde at davidedmundson.co.uk
Fri Apr 6 22:20:50 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104431/
-----------------------------------------------------------

(Updated April 6, 2012, 10:20 p.m.)


Review request for Plasma.


Changes
-------

Fix diff.


Description
-------

* Remove "runner" from "Nepomuk Desktop Search Runner" as the runner is implied from the context and to bring consistency.
* Add correct icon for activities runner
* Use correct case in description of "places" runner.
* Use correct case in Webshorts runner description
* Match top and bottom margin sizes. This updates a bodge that removed 2 pixels from the top margin to only use 1.
* Reword "Available Features" to "Available Plugins" for consistency
* Make the krunner config dialog appear to load slightly faster by loading the list of plugins after we've shown the dialog.
* Remove undefined (and unused) private method.


Diffs (updated)
-----

  krunner/configdialog.h a9c353a 
  krunner/configdialog.cpp 80485ca 
  krunner/krunnerdialog.cpp 007887f 
  plasma/generic/runners/activities/plasma-runner-activityrunner.desktop 853c680 
  plasma/generic/runners/nepomuksearch/plasma-runner-nepomuksearch.desktop 0319463 
  plasma/generic/runners/places/plasma-runner-places.desktop b82fa14 
  plasma/generic/runners/webshortcuts/plasma-runner-webshortcuts.desktop f234b4f 

Diff: http://git.reviewboard.kde.org/r/104431/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20120406/335db31a/attachment.html>


More information about the Plasma-devel mailing list