Review Request: XTest is an optional dependency, so skip a test that requires it if it is not found

Ralf Jung ralfjung-e at gmx.de
Wed Oct 5 08:56:28 UTC 2011



> On Oct. 5, 2011, 1:53 a.m., Aaron J. Seigo wrote:
> > Ship It!

Could someone please do that for me? I do not have commit access.


- Ralf


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102771/#review7094
-----------------------------------------------------------


On Oct. 4, 2011, 6:52 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102771/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2011, 6:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Running cmake without having libxtest fails as some tests that are always compiled use it unconditionally. This fixes these tests to be only compiled if libxtest is found, as it is marked as optional dependency.
> 
> 
> Diffs
> -----
> 
>   kcontrol/keyboard/tests/CMakeLists.txt 419d150 
> 
> Diff: http://git.reviewboard.kde.org/r/102771/diff/diff
> 
> 
> Testing
> -------
> 
> kde-workspace compiles now.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111005/6662c2fa/attachment.html>


More information about the Plasma-devel mailing list