Review Request: XTest is an optional dependency, so skip a test that requires it if it is not found

Commit Hook null at kde.org
Wed Oct 5 10:05:01 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102771/#review7111
-----------------------------------------------------------


This review has been submitted with commit ad68a0e4f51425400a376be6bcec0cfb448d9104 by Aaron Seigo to branch master.

- Commit Hook


On Oct. 4, 2011, 6:52 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102771/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2011, 6:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Running cmake without having libxtest fails as some tests that are always compiled use it unconditionally. This fixes these tests to be only compiled if libxtest is found, as it is marked as optional dependency.
> 
> 
> Diffs
> -----
> 
>   kcontrol/keyboard/tests/CMakeLists.txt 419d150 
> 
> Diff: http://git.reviewboard.kde.org/r/102771/diff/diff
> 
> 
> Testing
> -------
> 
> kde-workspace compiles now.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111005/f231342c/attachment.html>


More information about the Plasma-devel mailing list