Review Request: XTest is an optional dependency, so skip a test that requires it if it is not found
Aaron J. Seigo
aseigo at kde.org
Wed Oct 5 01:53:53 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102771/#review7094
-----------------------------------------------------------
Ship it!
Ship It!
- Aaron J. Seigo
On Oct. 4, 2011, 6:52 p.m., Ralf Jung wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102771/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2011, 6:52 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Running cmake without having libxtest fails as some tests that are always compiled use it unconditionally. This fixes these tests to be only compiled if libxtest is found, as it is marked as optional dependency.
>
>
> Diffs
> -----
>
> kcontrol/keyboard/tests/CMakeLists.txt 419d150
>
> Diff: http://git.reviewboard.kde.org/r/102771/diff/diff
>
>
> Testing
> -------
>
> kde-workspace compiles now.
>
>
> Thanks,
>
> Ralf Jung
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111005/2d1579f2/attachment.html>
More information about the Plasma-devel
mailing list