Review Request: Plasmate can create a CMakeLists.txt at $my_plasmoid dir

[Aaron J. Seigo]

> On Oct. 30, 2011, 8:03 a.m., Aaron J. Seigo wrote:
> > why is a CMakeLists.txt needed? plasmapkg is enough, no?
> 
> Sebastian Kügler wrote:
>     CMakeLists.txt is needed if you want to package the package (for OBS, for example).
> 
> Aaron J. Seigo wrote:
>     shouldn't that be part of the publishing step then?
> 
> Giorgos Tsiapaliwkas wrote:
>     What should i do with this patch?
>     thanks

my opinion is that this is part of the publishing step. normally, a plasmoid / dataengine / etc has _no need_ for a build system whatsoever. you only know that it does need one (and which one it needs) at publishing time. so this would become part of publishing, and could even become another possible optoin in that dialog.

and once a publishing option is chosen, then it can be added to the project's git repository.

what i'm trying to avoid here is making plasmate support build systems in general (a very complex topic to do "right") as well as building into plasmate assumptions such as "it is best built with cmake".


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102989/#review7755
-----------------------------------------------------------


On Oct. 29, 2011, 4:45 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102989/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2011, 4:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> With this patch plasmate can now create a CMakeLists.txt.I haven't discussed the patch with someone but i believe that plasmate needs this feature.
> 
> If so,at the publisher there is an install button should i convert it into a combobox in order to add the option to install the project using
> cmake and not only using plasmapkg.Of course this will be an another patch.
> 
> thanks in advance
> 
> 
> Diffs
> -----
> 
>   startpage.cpp fc00441 
>   templates/CMakeLists.txt b5f8d2b 
>   templates/cmakelists e69de29 
> 
> Diff: http://git.reviewboard.kde.org/r/102989/diff/diff
> 
> 
> Testing
> -------
> 
> the source code is fine,i am not sure about the quality of the CMakeLists.txt file
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111116/4a03cf0c/attachment-0001.html>