Review Request: Plasmate can create a CMakeLists.txt at $my_plasmoid dir

Giorgos Tsiapaliwkas terietor at gmail.com
Wed Nov 23 15:00:54 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102989/
-----------------------------------------------------------

(Updated Nov. 23, 2011, 3 p.m.)


Review request for Plasma.


Changes
-------

i updated the diff and i replaced the pushbutton with a combobox

thanks in advance


Description
-------

With this patch plasmate can now create a CMakeLists.txt.I haven't discussed the patch with someone but i believe that plasmate needs this feature.

If so,at the publisher there is an install button should i convert it into a combobox in order to add the option to install the project using
cmake and not only using plasmapkg.Of course this will be an another patch.

thanks in advance


Diffs (updated)
-----

  publisher/publisher.h 39b1f22 
  publisher/publisher.cpp fec24c8 
  templates/CMakeLists.txt b5f8d2b 

Diff: http://git.reviewboard.kde.org/r/102989/diff/diff


Testing
-------

the source code is fine,i am not sure about the quality of the CMakeLists.txt file


Thanks,

Giorgos Tsiapaliwkas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111123/4ec9ed86/attachment.html>


More information about the Plasma-devel mailing list