<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102989/">http://git.reviewboard.kde.org/r/102989/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 30th, 2011, 8:03 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">why is a CMakeLists.txt needed? plasmapkg is enough, no?</pre>
</blockquote>
<p>On November 1st, 2011, 10:10 a.m., <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CMakeLists.txt is needed if you want to package the package (for OBS, for example).</pre>
</blockquote>
<p>On November 1st, 2011, 10:17 a.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">shouldn't that be part of the publishing step then?</pre>
</blockquote>
<p>On November 12th, 2011, 7:31 p.m., <b>Giorgos Tsiapaliwkas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What should i do with this patch?
thanks</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">my opinion is that this is part of the publishing step. normally, a plasmoid / dataengine / etc has _no need_ for a build system whatsoever. you only know that it does need one (and which one it needs) at publishing time. so this would become part of publishing, and could even become another possible optoin in that dialog.
and once a publishing option is chosen, then it can be added to the project's git repository.
what i'm trying to avoid here is making plasmate support build systems in general (a very complex topic to do "right") as well as building into plasmate assumptions such as "it is best built with cmake".</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On October 29th, 2011, 4:45 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Oct. 29, 2011, 4:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With this patch plasmate can now create a CMakeLists.txt.I haven't discussed the patch with someone but i believe that plasmate needs this feature.
If so,at the publisher there is an install button should i convert it into a combobox in order to add the option to install the project using
cmake and not only using plasmapkg.Of course this will be an another patch.
thanks in advance</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the source code is fine,i am not sure about the quality of the CMakeLists.txt file</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>startpage.cpp <span style="color: grey">(fc00441)</span></li>
<li>templates/CMakeLists.txt <span style="color: grey">(b5f8d2b)</span></li>
<li>templates/cmakelists <span style="color: grey">(e69de29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102989/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>