Review Request: Screen Locker daemon

[Oswald Buddenhagen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103105/#review8125
-----------------------------------------------------------


for now only a quick note from me: i won't give you the "ship it" with such a todo list; it completely perverts the idea of feature freeze. but, as coolo said long ago "feature freeze only means that everybody gets a bad conscience when submitting features". it's perfectly ok if you submit it three days after the deadline if you promise to personally coerce at least two and a half people to do Thorough Testing ™ for you.

fwiw, i'd rename kscreenunlocker to ksld_greet for clarity and consistency with kdm. also, ksld is not too well chosen, as it does't naturally associate with anything - kscreenlocker should be fine, no?

- Oswald Buddenhagen


On Nov. 10, 2011, 12:16 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103105/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2011, 12:16 p.m.)
> 
> 
> Review request for kwin, Plasma and Oswald Buddenhagen.
> 
> 
> Description
> -------
> 
> Yes I know it's late in the cycle :-) and yes not everything is implemented yet, but I am confident that I get these things finished today or at least till Beta tagging.
> 
> This is the new screenlocker work as discussed on kcd some time ago.
> 
> The screen locker is split into two parts:
> 1. A daemon (ksld) to just lock the screen and grab input
> 2. An unlock dialog (kscreenunlocker) which is executed as a separate process.
>     
> In case the unlocker fails/crashes the screen is still locked by
> the lock daemon.
>     
> In case kscreenunlocker crashes or does not succeed, it gets
> automatically restarted by the daemon.
> 
> Things I still need to do:
> * D-Bus integration
> * Grace time
> * integration of existing screen savers into the QML
> * cleanup KRunner
> * several more things
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9fa4c10 
>   screenlocker/CMakeLists.txt PRE-CREATION 
>   screenlocker/kcfg/kscreensaversettings.kcfg PRE-CREATION 
>   screenlocker/kcfg/kscreensaversettings.kcfgc PRE-CREATION 
>   screenlocker/ksld.desktop PRE-CREATION 
>   screenlocker/ksldapp.h PRE-CREATION 
>   screenlocker/ksldapp.cpp PRE-CREATION 
>   screenlocker/lockwindow.h PRE-CREATION 
>   screenlocker/lockwindow.cpp PRE-CREATION 
>   screenlocker/main.cpp PRE-CREATION 
>   screenlocker/unlocker/CMakeLists.txt PRE-CREATION 
>   screenlocker/unlocker/main.cpp PRE-CREATION 
>   screenlocker/unlocker/qml/lockscreen.qml PRE-CREATION 
>   screenlocker/unlocker/unlockapp.h PRE-CREATION 
>   screenlocker/unlocker/unlockapp.cpp PRE-CREATION 
>   screenlocker/unlocker/unlocker.h PRE-CREATION 
>   screenlocker/unlocker/unlocker.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103105/diff/diff
> 
> 
> Testing
> -------
> 
> * Screen locks
> * Screen stays locked if unlocker crasher
> * unlocker gets restarted
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111111/f0c85d69/attachment.html>