Review Request: Fix bug 268798: Interference of plasma popups.

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103025/#review7900
-----------------------------------------------------------

Ship it!


this can be applied to the 4.7 branch, but there is no point in applying it to master (see Xuetian's comment)


applets/kimpanel/src/kimpanelapplet.cpp
<http://git.reviewboard.kde.org/r/103025/#comment6819>

    while this is the shortest / easiest solution, i can't help but think that it would be much easier to just use a normal QGraphicsScene instead of a Corona. the only thing Corona is used for in this code is the addOffscreenWidget method. it could just as easily be done with a QGraphicsScene and a simple QGraphicsLinearLayout ...
    
    however, as this is being replaced in 4.8, it probably hardly matters.


- Aaron J. Seigo


On Nov. 2, 2011, 12:08 a.m., Andrew Fuller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103025/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2011, 12:08 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Kimpanel was attaching to the corona belonging to the entire desktop.  This resulted in come mouse events being eaten (moving apps between virtual desktops via the pager ceased to function) and the placement of popups were miscalculated (the K-menu, taskbar and systray popups all appear somewhere else on the screen than where they belong).
> Give kimpanel its own corona to play in so he can peacefully coexist with the rest of the world.
> 
> 
> This addresses bug 268798.
>     http://bugs.kde.org/show_bug.cgi?id=268798
> 
> 
> Diffs
> -----
> 
>   applets/kimpanel/src/kimpanelapplet.cpp c64546a 
> 
> Diff: http://git.reviewboard.kde.org/r/103025/diff/diff
> 
> 
> Testing
> -------
> 
> Tested on two machines (both Kubuntu 11.10).  Kimpanel no longer interferes with other plasmoids.
> 
> 
> Thanks,
> 
> Andrew Fuller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111103/1440c4c7/attachment.html>