<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103025/">http://git.reviewboard.kde.org/r/103025/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this can be applied to the 4.7 branch, but there is no point in applying it to master (see Xuetian's comment)</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103025/diff/1/?file=40105#file40105line117" style="color: black; font-weight: bold; text-decoration: underline;">applets/kimpanel/src/kimpanelapplet.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KIMPanelApplet::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">116</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_lookup_table</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KIMLookupTable</span><span class="p">(</span><span class="n">m_panel_agent</span><span class="p">,</span> <span class="k"><span class="hl">static_cast</span></span><span class="o"><span class="hl"><</span></span><span class="n"><span class="hl">Plasma</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">C</span>orona</span><span class="hl"> </span><span class="o"><span class="hl">*></span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">scene</span></span><span class="p"><span class="hl">())</span>);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">117</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_lookup_table</span> <span class="o">=</span> <span class="k">new</span> <span class="n">KIMLookupTable</span><span class="p">(</span><span class="n">m_panel_agent</span><span class="p">,</span> <span class="n"><span class="hl">c</span>orona</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">while this is the shortest / easiest solution, i can't help but think that it would be much easier to just use a normal QGraphicsScene instead of a Corona. the only thing Corona is used for in this code is the addOffscreenWidget method. it could just as easily be done with a QGraphicsScene and a simple QGraphicsLinearLayout ...
however, as this is being replaced in 4.8, it probably hardly matters.</pre>
</div>
<br />
<p>- Aaron J.</p>
<br />
<p>On November 2nd, 2011, 12:08 a.m., Andrew Fuller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andrew Fuller.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2011, 12:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kimpanel was attaching to the corona belonging to the entire desktop. This resulted in come mouse events being eaten (moving apps between virtual desktops via the pager ceased to function) and the placement of popups were miscalculated (the K-menu, taskbar and systray popups all appear somewhere else on the screen than where they belong).
Give kimpanel its own corona to play in so he can peacefully coexist with the rest of the world.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on two machines (both Kubuntu 11.10). Kimpanel no longer interferes with other plasmoids.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=268798">268798</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kimpanel/src/kimpanelapplet.cpp <span style="color: grey">(c64546a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103025/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>