Review Request: Fix bug 268798: Interference of plasma popups.

[Aaron J. Seigo]

> On Nov. 3, 2011, 9:18 a.m., Xuetian Weng wrote:
> > Emm, actually I have already a rewrite version (which I plan to merge in 4.8). https://projects.kde.org/projects/playground/base/kimpanel, and this is already fixed. I though I don't know whether this is need to be ported to 4.7.

this merge should happen as soon as possible as we're moving into feature freeze. there seems to be quite some push-back from packagers and others on having the input panel in its own repository; i think that for Plasma Desktop 2, based on libplasma2 from frameworks 5, we can split things into more sensible repositories. for 4.x, however, it seems that the easiest thing will be to put the kimpanel rewrite in kdeplasma-addons.

so .. my suggestion: 

* remove kimpanel from kdeplasma-addons
* put kimpanel/applet in kdeplasma-addons/applets/kimpanel
* put kimpanel/dataengine in kdeplasma-addons/dataengines/kimpanel

then when we move to Frameworks 5 and libplasma 2, i can set up some git filter-branch runs to put all the input things (virtual keyboard, multi-byte input, etc) from kdeplasma-addons into their repository.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103025/#review7897
-----------------------------------------------------------


On Nov. 2, 2011, 12:08 a.m., Andrew Fuller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103025/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2011, 12:08 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Kimpanel was attaching to the corona belonging to the entire desktop.  This resulted in come mouse events being eaten (moving apps between virtual desktops via the pager ceased to function) and the placement of popups were miscalculated (the K-menu, taskbar and systray popups all appear somewhere else on the screen than where they belong).
> Give kimpanel its own corona to play in so he can peacefully coexist with the rest of the world.
> 
> 
> This addresses bug 268798.
>     http://bugs.kde.org/show_bug.cgi?id=268798
> 
> 
> Diffs
> -----
> 
>   applets/kimpanel/src/kimpanelapplet.cpp c64546a 
> 
> Diff: http://git.reviewboard.kde.org/r/103025/diff/diff
> 
> 
> Testing
> -------
> 
> Tested on two machines (both Kubuntu 11.10).  Kimpanel no longer interferes with other plasmoids.
> 
> 
> Thanks,
> 
> Andrew Fuller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111103/7b75125d/attachment-0001.html>