<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103025/">http://git.reviewboard.kde.org/r/103025/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 3rd, 2011, 9:18 a.m., <b>Xuetian Weng</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Emm, actually I have already a rewrite version (which I plan to merge in 4.8). https://projects.kde.org/projects/playground/base/kimpanel, and this is already fixed. I though I don't know whether this is need to be ported to 4.7.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this merge should happen as soon as possible as we're moving into feature freeze. there seems to be quite some push-back from packagers and others on having the input panel in its own repository; i think that for Plasma Desktop 2, based on libplasma2 from frameworks 5, we can split things into more sensible repositories. for 4.x, however, it seems that the easiest thing will be to put the kimpanel rewrite in kdeplasma-addons.
so .. my suggestion:
* remove kimpanel from kdeplasma-addons
* put kimpanel/applet in kdeplasma-addons/applets/kimpanel
* put kimpanel/dataengine in kdeplasma-addons/dataengines/kimpanel
then when we move to Frameworks 5 and libplasma 2, i can set up some git filter-branch runs to put all the input things (virtual keyboard, multi-byte input, etc) from kdeplasma-addons into their repository.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On November 2nd, 2011, 12:08 a.m., Andrew Fuller wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Andrew Fuller.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2011, 12:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kimpanel was attaching to the corona belonging to the entire desktop. This resulted in come mouse events being eaten (moving apps between virtual desktops via the pager ceased to function) and the placement of popups were miscalculated (the K-menu, taskbar and systray popups all appear somewhere else on the screen than where they belong).
Give kimpanel its own corona to play in so he can peacefully coexist with the rest of the world.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on two machines (both Kubuntu 11.10). Kimpanel no longer interferes with other plasmoids.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=268798">268798</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/kimpanel/src/kimpanelapplet.cpp <span style="color: grey">(c64546a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103025/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>