Review Request: Fix Panel Shadow when Plasma is using graphicssystem raster
Commit Hook
null at kde.org
Fri May 20 17:24:03 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101367/#review3421
-----------------------------------------------------------
This review has been submitted with commit 37ca3f30d28ef2405f5cb41033f6bc0b96473ee5 by Martin Gräßlin.
- Commit
On May 17, 2011, 5:10 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101367/
> -----------------------------------------------------------
>
> (Updated May 17, 2011, 5:10 p.m.)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> As QPixmap::handle is not returning something useful if run with graphicssystem raster, we need to check if the handle is valid. If not we need to create an XPixmap, create a QPixmap from it (then handle returns useful info) and perform a deep copy of the pixmap's content.
>
>
> Diffs
> -----
>
> libs/plasmagenericshell/panelshadows.cpp 3a27992
>
> Diff: http://git.reviewboard.kde.org/r/101367/diff
>
>
> Testing
> -------
>
> Shadows with Graphicssystem Raster: OK
>
> Shadows with Graphicssystem Native: OK
>
>
> Thanks,
>
> Martin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110520/a694970a/attachment.htm
More information about the Plasma-devel
mailing list