Review Request: Fix Panel Shadow when Plasma is using graphicssystem raster

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101367/
-----------------------------------------------------------

(Updated May 17, 2011, 5:10 p.m.)


Review request for Plasma.


Changes
-------

Let's make it more ugly: we need to XFree the pixmaps or we leak if we create them ourselves.

It would be nice if QPixmap would provide something like toX11Pixmap...


Summary
-------

As QPixmap::handle is not returning something useful if run with graphicssystem raster, we need to check if the handle is valid. If not we need to create an XPixmap, create a QPixmap from it (then handle returns useful info) and perform a deep copy of the pixmap's content.


Diffs (updated)
-----

  libs/plasmagenericshell/panelshadows.cpp 3a27992 

Diff: http://git.reviewboard.kde.org/r/101367/diff


Testing
-------

Shadows with Graphicssystem Raster: OK

Shadows with Graphicssystem Native: OK


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110517/8a637d11/attachment.htm