Review Request: Fix Panel Shadow when Plasma is using graphicssystem raster

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101367/#review3357
-----------------------------------------------------------

Ship it!


that is rather ugly, though that isn't the fault of your code. at least it can be contained in a single place. go for it ...

- Aaron J.


On May 15, 2011, 7:29 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101367/
> -----------------------------------------------------------
> 
> (Updated May 15, 2011, 7:29 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> As QPixmap::handle is not returning something useful if run with graphicssystem raster, we need to check if the handle is valid. If not we need to create an XPixmap, create a QPixmap from it (then handle returns useful info) and perform a deep copy of the pixmap's content.
> 
> 
> Diffs
> -----
> 
>   libs/plasmagenericshell/panelshadows.cpp 3a27992 
> 
> Diff: http://git.reviewboard.kde.org/r/101367/diff
> 
> 
> Testing
> -------
> 
> Shadows with Graphicssystem Raster: OK
> 
> Shadows with Graphicssystem Native: OK
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110517/a7759880/attachment.htm