Review Request: Fix Panel Shadow when Plasma is using graphicssystem raster

Martin Gräßlin kde at martin-graesslin.com
Sun May 15 09:29:47 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101367/
-----------------------------------------------------------

(Updated May 15, 2011, 7:29 a.m.)


Review request for Plasma.


Changes
-------

Fix include


Summary
-------

As QPixmap::handle is not returning something useful if run with graphicssystem raster, we need to check if the handle is valid. If not we need to create an XPixmap, create a QPixmap from it (then handle returns useful info) and perform a deep copy of the pixmap's content.


Diffs (updated)
-----

  libs/plasmagenericshell/panelshadows.cpp 3a27992 

Diff: http://git.reviewboard.kde.org/r/101367/diff


Testing
-------

Shadows with Graphicssystem Raster: OK

Shadows with Graphicssystem Native: OK


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110515/9ba815b4/attachment.htm 


More information about the Plasma-devel mailing list