Review Request: Activity ResourceInstance class for API review

Aaron J. Seigo aseigo at kde.org
Mon May 2 15:09:19 CEST 2011



> On May 2, 2011, 1:03 p.m., Sebastian Trueg wrote:
> > experimental/libkactivities/ResourceInstance.h, line 62
> > <http://git.reviewboard.kde.org/r/101273/diff/1/?file=15799#file15799line62>
> >
> >     What is the mimetype required for? Some resources might not even have a "real" mimetype.

if they don't have a mimetype, that's fine. but if they already know the mimetype, it prevents additional lookups. this is particularly useful if the content is not otherwise directly addressable by an external app (say .. a map route in marble :)


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101273/#review3043
-----------------------------------------------------------


On May 2, 2011, 1:07 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101273/
> -----------------------------------------------------------
> 
> (Updated May 2, 2011, 1:07 p.m.)
> 
> 
> Review request for Nepomuk and Plasma.
> 
> 
> Summary
> -------
> 
> Desc of the class is in the class apidocs
> 
> 
> Diffs
> -----
> 
>   experimental/libkactivities/ResourceInstance.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101273/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110502/076d39f3/attachment.htm 


More information about the Plasma-devel mailing list