Review Request: Activity ResourceInstance class for API review

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101273/#review3043
-----------------------------------------------------------



experimental/libkactivities/ResourceInstance.h
<http://git.reviewboard.kde.org/r/101273/#comment2597>

    What is the mimetype required for? Some resources might not even have a "real" mimetype.



experimental/libkactivities/ResourceInstance.h
<http://git.reviewboard.kde.org/r/101273/#comment2594>

    How about an event enum instead of one method for each event type? Something like resourceAccessed(Type)



experimental/libkactivities/ResourceInstance.h
<http://git.reviewboard.kde.org/r/101273/#comment2598>

    As mentioned on IRC I am not sure about this. How would accessing the new resource be handled then? Normally creating the RI instance does that. But if the resource changes regularly how do I tell the system that I accessed the new resource/URI?


- Sebastian


On May 2, 2011, 12:50 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101273/
> -----------------------------------------------------------
> 
> (Updated May 2, 2011, 12:50 p.m.)
> 
> 
> Review request for Nepomuk, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian Trueg.
> 
> 
> Summary
> -------
> 
> Desc of the class is in the class apidocs
> 
> 
> Diffs
> -----
> 
>   experimental/libkactivities/ResourceInstance.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101273/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110502/ac05862a/attachment.htm