Review Request: Activity ResourceInstance class for API review

[Ivan Čukić]

> On May 2, 2011, 1:03 p.m., Sebastian Trueg wrote:
> > experimental/libkactivities/ResourceInstance.h, line 77
> > <http://git.reviewboard.kde.org/r/101273/diff/1/?file=15799#file15799line77>
> >
> >     How about an event enum instead of one method for each event type? Something like resourceAccessed(Type)

I wanted to avoid it - this is not something that should register various events like open and close which are invoked automatically.

If this method gets the /event type/ ppl will be able to call open multiple times...

If you can imagine another event that is not open/close/moddify, then yes. If not, I'd like eit better this way.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101273/#review3043
-----------------------------------------------------------


On May 2, 2011, 1:07 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101273/
> -----------------------------------------------------------
> 
> (Updated May 2, 2011, 1:07 p.m.)
> 
> 
> Review request for Nepomuk and Plasma.
> 
> 
> Summary
> -------
> 
> Desc of the class is in the class apidocs
> 
> 
> Diffs
> -----
> 
>   experimental/libkactivities/ResourceInstance.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101273/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110502/ab669acf/attachment-0001.htm