Review Request: Adding "Set Wallpaper Image" option in Picture frame

Sinny Kumari ksinny at gmail.com
Thu Mar 17 15:21:43 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100764/
-----------------------------------------------------------

(Updated March 17, 2011, 2:21 p.m.)


Review request for Plasma.


Changes
-------

changes done to avoid crash


Summary
-------

Adding "Set Wallpaper Image" feature in Picture Frame. If the User right clicks on Picture Frame, there will be an option "Set Wallpaper Image". This Option will set the current Image Of Picture Frame as Wallpaper Image. Done changes according to suggestion given by Todd and Aaron. Continuation of http://svn.reviewboard.kde.org/r/6416/.


Diffs (updated)
-----

  applets/frame/frame.h bf7b95d 
  applets/frame/frame.cpp 871ebef 

Diff: http://git.reviewboard.kde.org/r/100764/diff


Testing
-------

working fine
Added  QTimer::singleShot(300,this, SLOT(setImageAsWallpaper())); line in frame.cpp because Plugin takes some time to load.
Not sure it is correct way to do or not. Any suggestion?


Thanks,

Sinny

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110317/b578ad4f/attachment.htm 


More information about the Plasma-devel mailing list