Review Request: Adding "Set Wallpaper Image" option in Picture frame

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100764/#review2012
-----------------------------------------------------------

Ship it!


looks good; one small crash prevention issue, and then please commit :)


applets/frame/frame.cpp
<http://git.reviewboard.kde.org/r/100764/#comment1683>

    possibly crashable if the containment doesn't have a wallpaper; a separate variable probably isn't needed for this. just:
    
    if (containment()->wallpaper() &&
        containment()->wallpaper()->supportsMimetype(KMimeType::findByUrl(url)->name()) {


- Aaron J.


On March 3, 2011, 6:56 p.m., Sinny Kumari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100764/
> -----------------------------------------------------------
> 
> (Updated March 3, 2011, 6:56 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Adding "Set Wallpaper Image" feature in Picture Frame. If the User right clicks on Picture Frame, there will be an option "Set Wallpaper Image". This Option will set the current Image Of Picture Frame as Wallpaper Image. Done changes according to suggestion given by Todd and Aaron. Continuation of http://svn.reviewboard.kde.org/r/6416/.
> 
> 
> Diffs
> -----
> 
>   applets/frame/frame.h bf7b95d 
>   applets/frame/frame.cpp 871ebef 
> 
> Diff: http://git.reviewboard.kde.org/r/100764/diff
> 
> 
> Testing
> -------
> 
> working fine
> Added  QTimer::singleShot(300,this, SLOT(setImageAsWallpaper())); line in frame.cpp because Plugin takes some time to load.
> Not sure it is correct way to do or not. Any suggestion?
> 
> 
> Thanks,
> 
> Sinny
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110317/25a202b6/attachment.htm