Review Request: Adding "Set Wallpaper Image" option in Picture frame
Sinny Kumari
ksinny at gmail.com
Thu Mar 3 19:56:11 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100764/
-----------------------------------------------------------
(Updated March 3, 2011, 6:56 p.m.)
Review request for Plasma.
Changes
-------
Removed and added whitespaces wherever required. Without QTimer it is working fine now.
Please, check if still I missed something in the code.
Thanks
Summary
-------
Adding "Set Wallpaper Image" feature in Picture Frame. If the User right clicks on Picture Frame, there will be an option "Set Wallpaper Image". This Option will set the current Image Of Picture Frame as Wallpaper Image. Done changes according to suggestion given by Todd and Aaron. Continuation of http://svn.reviewboard.kde.org/r/6416/.
Diffs (updated)
-----
applets/frame/frame.h bf7b95d
applets/frame/frame.cpp 871ebef
Diff: http://git.reviewboard.kde.org/r/100764/diff
Testing
-------
working fine
Added QTimer::singleShot(300,this, SLOT(setImageAsWallpaper())); line in frame.cpp because Plugin takes some time to load.
Not sure it is correct way to do or not. Any suggestion?
Thanks,
Sinny
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110303/98b3babb/attachment.htm
More information about the Plasma-devel
mailing list