Review Request: Add a system tray option to always show all items

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100743/#review1667
-----------------------------------------------------------


hmm i'm not sure about it, i don't see an huge use case of showing icons that are meant to be passive (so not telling anything useful at the moment)

however the patch is well done (i appreciate disabling the combo boxes when the always show all option is checked)
so hmm, yeah, i'm a bit on the fence on this one but if there aren't other objections i think it can go in

- Marco


On Feb. 25, 2011, 4:33 p.m., Jonathan Marten wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100743/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2011, 4:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> If the user wishes to have all system tray items visible at all times, there is no single setting to allow this.  The only option is to go to System Tray Settings - Entries and set all of the "Visibility" combo boxes to "Always Visible", and repeat this whenever a new item appears.
> 
> All versions of a popular closed source operating system have this option for the system tray.
> 
> This change adds a check box "Always show all system tray items" below the list on the Entries page.  Checking this sets all items (current and any new ones that may appear in future) to be always visible and disables the "Visibility" column.  It is still possible to access the "Keyboard Shortcut" column.
> 
> The default is for this option not to be set, so the system tray operation is the same as before.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/systemtray/ui/applet.h b0e9a55 
>   plasma/generic/applets/systemtray/ui/applet.cpp bd2d8ff 
>   plasma/generic/applets/systemtray/ui/autohide.ui 3b6efff 
>   plasma/generic/applets/systemtray/ui/taskarea.h 091763c 
>   plasma/generic/applets/systemtray/ui/taskarea.cpp cfa503b 
> 
> Diff: http://git.reviewboard.kde.org/r/100743/diff
> 
> 
> Testing
> -------
> 
> Built kde-workspace with these changes, checked operation of system tray and settings dialogue with this option checked and not checked.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110226/a2d1939c/attachment.htm