<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100743/">http://git.reviewboard.kde.org/r/100743/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hmm i'm not sure about it, i don't see an huge use case of showing icons that are meant to be passive (so not telling anything useful at the moment)
however the patch is well done (i appreciate disabling the combo boxes when the always show all option is checked)
so hmm, yeah, i'm a bit on the fence on this one but if there aren't other objections i think it can go in</pre>
<br />
<p>- Marco</p>
<br />
<p>On February 25th, 2011, 4:33 p.m., Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2011, 4:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the user wishes to have all system tray items visible at all times, there is no single setting to allow this. The only option is to go to System Tray Settings - Entries and set all of the "Visibility" combo boxes to "Always Visible", and repeat this whenever a new item appears.
All versions of a popular closed source operating system have this option for the system tray.
This change adds a check box "Always show all system tray items" below the list on the Entries page. Checking this sets all items (current and any new ones that may appear in future) to be always visible and disables the "Visibility" column. It is still possible to access the "Keyboard Shortcut" column.
The default is for this option not to be set, so the system tray operation is the same as before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built kde-workspace with these changes, checked operation of system tray and settings dialogue with this option checked and not checked.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/systemtray/ui/applet.h <span style="color: grey">(b0e9a55)</span></li>
<li>plasma/generic/applets/systemtray/ui/applet.cpp <span style="color: grey">(bd2d8ff)</span></li>
<li>plasma/generic/applets/systemtray/ui/autohide.ui <span style="color: grey">(3b6efff)</span></li>
<li>plasma/generic/applets/systemtray/ui/taskarea.h <span style="color: grey">(091763c)</span></li>
<li>plasma/generic/applets/systemtray/ui/taskarea.cpp <span style="color: grey">(cfa503b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100743/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>