Review Request: remove Assert on collection id change

[Mario Bensi]

> On Feb. 4, 2011, 6:54 p.m., Sergio Luis Martins wrote:
> > I don't know if calendar.cpp will support moves just by removing that assert. Will have to read the code in the weekend.

I'm not sure the code support moves but this remove don't create new crash.


- Mario


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100523/#review1229
-----------------------------------------------------------


On Feb. 2, 2011, 8:19 a.m., Mario Bensi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100523/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2011, 8:19 a.m.)
> 
> 
> Review request for KDEPIM and Plasma.
> 
> 
> Summary
> -------
> 
> Actually, there is an assert when the collection id are not the same you
> are store in your cache. I work on Zanshin and I can move an Item from a
> Collection to another and i can reproduce the same behaviour with akonadiconsole.
> 
> This path remove the assert on this case and avoid a crash when we move
> the item to a different collection.
> 
> I add kdepim in groups because a part of the code comes from kdepim/akonadi/kcal
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/calendar/akonadi/calendar.cpp 71e4fe6 
> 
> Diff: http://git.reviewboard.kde.org/r/100523/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110206/e3ed0e32/attachment.htm