<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100523/">http://git.reviewboard.kde.org/r/100523/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 4th, 2011, 6:54 p.m., <b>Sergio Luis Martins</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't know if calendar.cpp will support moves just by removing that assert. Will have to read the code in the weekend.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure the code support moves but this remove don't create new crash.</pre>
<br />
<p>- Mario</p>
<br />
<p>On February 2nd, 2011, 8:19 a.m., Mario Bensi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDEPIM and Plasma.</div>
<div>By Mario Bensi.</div>
<p style="color: grey;"><i>Updated Feb. 2, 2011, 8:19 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually, there is an assert when the collection id are not the same you
are store in your cache. I work on Zanshin and I can move an Item from a
Collection to another and i can reproduce the same behaviour with akonadiconsole.
This path remove the assert on this case and avoid a crash when we move
the item to a different collection.
I add kdepim in groups because a part of the code comes from kdepim/akonadi/kcal</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/calendar/akonadi/calendar.cpp <span style="color: grey">(71e4fe6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100523/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>