Review Request: remove Assert on collection id change
Sergio Luis Martins
iamsergio at gmail.com
Fri Feb 4 19:54:50 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100523/#review1229
-----------------------------------------------------------
I don't know if calendar.cpp will support moves just by removing that assert. Will have to read the code in the weekend.
- Sergio Luis
On Feb. 2, 2011, 8:19 a.m., Mario Bensi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100523/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2011, 8:19 a.m.)
>
>
> Review request for KDEPIM and Plasma.
>
>
> Summary
> -------
>
> Actually, there is an assert when the collection id are not the same you
> are store in your cache. I work on Zanshin and I can move an Item from a
> Collection to another and i can reproduce the same behaviour with akonadiconsole.
>
> This path remove the assert on this case and avoid a crash when we move
> the item to a different collection.
>
> I add kdepim in groups because a part of the code comes from kdepim/akonadi/kcal
>
>
> Diffs
> -----
>
> plasma/generic/dataengines/calendar/akonadi/calendar.cpp 71e4fe6
>
> Diff: http://git.reviewboard.kde.org/r/100523/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mario
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110204/c7f1ad7b/attachment.htm
More information about the Plasma-devel
mailing list