Review Request: Activities Dataengine: avoid calling KActivities::Controller::listActivities() unnecessarily

[Romário Rios]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103358/
-----------------------------------------------------------

(Updated Dec. 16, 2011, 12:25 a.m.)


Review request for Plasma.


Changes
-------

I think the bug I talked about before was fixed. Can I commit this?


Description
-------

Avoid calling listActivities to get the list of running activities everytime by getting it once, storing it in a private member and modifying this member as activities come and go.


Diffs
-----

  plasma/generic/dataengines/activities/activityengine.h cbbf94c 
  plasma/generic/dataengines/activities/activityengine.cpp 9436c34 

Diff: http://git.reviewboard.kde.org/r/103358/diff/diff


Testing (updated)
-------

Tested it now, removed some activities, added some more, stopped another bunch, and it seems to work just fine as long as I tested.


Thanks,

Romário Rios

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111216/f22aba1f/attachment.html>