Review Request: Activities Dataengine: avoid calling KActivities::Controller::listActivities() unnecessarily

[Romário Rios]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103358/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Avoid calling listActivities to get the list of running activities everytime by getting it once, storing it in a private member and modifying this member as activities come and go.


Diffs
-----

  plasma/generic/dataengines/activities/activityengine.h cbbf94c 
  plasma/generic/dataengines/activities/activityengine.cpp 9436c34 

Diff: http://git.reviewboard.kde.org/r/103358/diff/diff


Testing
-------

Stopping an activity - either in the activity manager or directly in plasmaengineexplorer - doesn't actually stop it, but I think this bug was present before I made any chanage to the dataengine, so it must be something in KActivities. Could someone confirm this, please?


Thanks,

Romário Rios

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111208/b81a7598/attachment.html>