Review Request: Activities Dataengine: avoid calling KActivities::Controller::listActivities() unnecessarily

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103358/#review9008
-----------------------------------------------------------

Ship it!



plasma/generic/dataengines/activities/activityengine.cpp
<http://git.reviewboard.kde.org/r/103358/#comment7469>

    can be made const.


- Aaron J. Seigo


On Dec. 16, 2011, 12:25 a.m., Romário Rios wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103358/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2011, 12:25 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Avoid calling listActivities to get the list of running activities everytime by getting it once, storing it in a private member and modifying this member as activities come and go.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/activities/activityengine.h cbbf94c 
>   plasma/generic/dataengines/activities/activityengine.cpp 9436c34 
> 
> Diff: http://git.reviewboard.kde.org/r/103358/diff/diff
> 
> 
> Testing
> -------
> 
> Tested it now, removed some activities, added some more, stopped another bunch, and it seems to work just fine as long as I tested.
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111216/8ddadc32/attachment.html>