Review Request: Makes Notes applet remember the Notes color change

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103353/#review8794
-----------------------------------------------------------


This review has been submitted with commit acb4d203d1d2e5ac3cad3be5bc2a13cddf4fc9d2 by Aaron Seigo to branch master.

- Commit Hook


On Dec. 7, 2011, 8:27 p.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103353/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2011, 8:27 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> The Notes applet does not apply the Notes color change, nor by right click or via the Settings dialog. The new color is not written in configuration. This was because m_topWidget->color() always returns yellow-notes as a color. 
> This patch introduces a new variable to store the color without the -notes and match it against the colors action menu.
> 
> Manuel, can you test please?
> 
> 
> This addresses bugs 288286 and 288286.
>     http://bugs.kde.org/show_bug.cgi?id=288286
>     http://bugs.kde.org/show_bug.cgi?id=288286
> 
> 
> Diffs
> -----
> 
>   applets/notes/notes.h fde13cc 
>   applets/notes/notes.cpp 10a8753 
> 
> Diff: http://git.reviewboard.kde.org/r/103353/diff/diff
> 
> 
> Testing
> -------
> 
> Tested and works as expected now, both on Desktop and dashboard.
> 
> Tested by Manuel who reported 288286, works for him. Waiting for the thumb up about the way it's fixed, maybe there's a cleaner way.
> 
> 
> Thanks,
> 
> Anne-Marie Mahfouf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111208/963e8cf3/attachment.html>