Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

[Giorgos Tsiapaliwkas]

> On July 31, 2011, 8:20 a.m., Aaron J. Seigo wrote:
> > savesystem/timeline.cpp, lines 236-256
> > <http://git.reviewboard.kde.org/r/102027/diff/2/?file=29736#file29736line236>
> >
> >     again, there is no benefit at all to these changes here. it even makes it more ambiguous who owns the actions and introduces memory management problems.
> 
> Giorgos Tsiapaliwkas wrote:
>     So,we want make this changes.
>     You know better than me :)

*So we won't make this changes.
I had a little mistype.


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102027/#review5251
-----------------------------------------------------------


On July 24, 2011, 8:51 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102027/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 8:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> hello,
> 
> the patch migrates the timeline.cpp from the Q classes to K classes.
> Also adds a KMessageBox::information in the newsavepoint(),in order to inform the user that he can't create a new save point without any changes being made
> 
> 
> Diffs
> -----
> 
>   savesystem/timeline.cpp 2ed3ac2 
> 
> Diff: http://git.reviewboard.kde.org/r/102027/diff
> 
> 
> Testing
> -------
> 
> no issues.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110816/c5a4a152/attachment-0001.html>