Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102027/#review5758
-----------------------------------------------------------



savesystem/timeline.cpp
<http://git.reviewboard.kde.org/r/102027/#comment5112>

    yes, it's fine that they are QActions here. there is nothing gained by changing it to KActions.
    
    qobject_cast is preferable and that's fine; it's just all the changes to KAction for no real purpose.


- Aaron J.


On July 24, 2011, 8:51 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102027/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 8:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> hello,
> 
> the patch migrates the timeline.cpp from the Q classes to K classes.
> Also adds a KMessageBox::information in the newsavepoint(),in order to inform the user that he can't create a new save point without any changes being made
> 
> 
> Diffs
> -----
> 
>   savesystem/timeline.cpp 2ed3ac2 
> 
> Diff: http://git.reviewboard.kde.org/r/102027/diff
> 
> 
> Testing
> -------
> 
> no issues.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110816/4b612ddc/attachment.html>