Review Request: Plasmate:migrate timeline.cpp from Q classes to K classes

[Giorgos Tsiapaliwkas]

> On July 31, 2011, 8:20 a.m., Aaron J. Seigo wrote:
> > the dialog box changes look good. the action changes don't. please commit the dialog changes ...

You mean the MessabeBoxs,correct?


> On July 31, 2011, 8:20 a.m., Aaron J. Seigo wrote:
> > savesystem/timeline.cpp, lines 236-256
> > <http://git.reviewboard.kde.org/r/102027/diff/2/?file=29736#file29736line236>
> >
> >     again, there is no benefit at all to these changes here. it even makes it more ambiguous who owns the actions and introduces memory management problems.

So,we want make this changes.
You know better than me :)


> On July 31, 2011, 8:20 a.m., Aaron J. Seigo wrote:
> > savesystem/timeline.cpp, line 378
> > <http://git.reviewboard.kde.org/r/102027/diff/2/?file=29736#file29736line378>
> >
> >     ws missing  here too

i will fix it.thanks


> On July 31, 2011, 8:20 a.m., Aaron J. Seigo wrote:
> > savesystem/timeline.cpp, line 409
> > <http://git.reviewboard.kde.org/r/102027/diff/2/?file=29736#file29736line409>
> >
> >     why?

Should we also leave this Actions to Q classes and not to K??

I used the qobject_cast instead of the dynamic_cast because you said that qobject_cast is more preferable.If i didn't understand correctly,I apologize.


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102027/#review5251
-----------------------------------------------------------


On July 24, 2011, 8:51 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102027/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 8:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> hello,
> 
> the patch migrates the timeline.cpp from the Q classes to K classes.
> Also adds a KMessageBox::information in the newsavepoint(),in order to inform the user that he can't create a new save point without any changes being made
> 
> 
> Diffs
> -----
> 
>   savesystem/timeline.cpp 2ed3ac2 
> 
> Diff: http://git.reviewboard.kde.org/r/102027/diff
> 
> 
> Testing
> -------
> 
> no issues.
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110806/21df9157/attachment-0001.html>