Review Request: Make the size of abstracticon uniform in plasma 'Add Widgets' dialog

[Reza Shah]

> On Aug. 12, 2011, 10:46 a.m., Marco Martin wrote:
> > libs/plasmagenericshell/abstracticon.cpp, line 97
> > <http://git.reviewboard.kde.org/r/102305/diff/1/?file=31703#file31703line97>
> >
> >     i'm fine with a fixed size not depending from the text anymore, looks cleaner, why doubling left and right margins tough?

I'm not sure the correct size, but seems no different with the non-double case. 
So i removed the multiplication in newer diff.


- Reza


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102305/#review5659
-----------------------------------------------------------


On Aug. 12, 2011, 3:01 p.m., Reza Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102305/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2011, 3:01 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> In current codes, the size of abstracticon will follow the size of widget name.
> My diff is to make the size of abstracticon uniform in plasma 'Add Widgets' dialog, 
> by making the widget name into 2 lines and elided the text.
> 
> 
> Diffs
> -----
> 
>   libs/plasmagenericshell/abstracticon.cpp 0fbdb9e 
> 
> Diff: http://git.reviewboard.kde.org/r/102305/diff
> 
> 
> Testing
> -------
> 
> Tested against master
> 
> 
> Thanks,
> 
> Reza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110812/1fa40f6d/attachment.html>