Review Request: Make the size of abstracticon uniform in plasma 'Add Widgets' dialog

Reza Shah rshah0385 at kireihana.com
Fri Aug 12 15:01:03 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102305/
-----------------------------------------------------------

(Updated Aug. 12, 2011, 3:01 p.m.)


Review request for Plasma, Aaron J. Seigo and Marco Martin.


Changes
-------

- Fix whitespace issue (i'm using kate, set indentation to 4 spaces).
- Fix halo drawing


Summary
-------

In current codes, the size of abstracticon will follow the size of widget name.
My diff is to make the size of abstracticon uniform in plasma 'Add Widgets' dialog, 
by making the widget name into 2 lines and elided the text.


Diffs (updated)
-----

  libs/plasmagenericshell/abstracticon.cpp 0fbdb9e 

Diff: http://git.reviewboard.kde.org/r/102305/diff


Testing
-------

Tested against master


Thanks,

Reza

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20110812/cbefbf18/attachment.html>


More information about the Plasma-devel mailing list