<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102305/">http://git.reviewboard.kde.org/r/102305/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 12th, 2011, 10:46 a.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102305/diff/1/?file=31703#file31703line97" style="color: black; font-weight: bold; text-decoration: underline;">libs/plasmagenericshell/abstracticon.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void AbstractIcon::resizeEvent(QGraphicsSceneResizeEvent *event)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">93</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QSizeF</span> <span class="n">s</span><span class="p">(</span><span class="n"><span class="hl">qMax</span></span><span class="p"><span class="hl">(</span></span><span class="n">m_iconHeight</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">fm</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">width</span></span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">m_name</span></span><span class="p"><span class="hl">))</span></span> <span class="o">+</span> <span class="n">l</span> <span class="o">+</span> <span class="n">r</span><span class="p">,</span> <span class="n">minHeight</span> <span class="o">+</span> <span class="n">t</span> <span class="o">+</span> <span class="n">b</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">97</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QSizeF</span> <span class="n">s</span><span class="p">(</span><span class="n">m_iconHeight</span><span class="o"><span class="hl">*</span></span><span class="mi"><span class="hl">2</span></span> <span class="o">+</span> <span class="mi"><span class="hl">2</span></span><span class="o"><span class="hl">*</span></span><span class="n">l</span> <span class="o">+</span> <span class="mi"><span class="hl">2</span></span><span class="o"><span class="hl">*</span></span><span class="n">r</span><span class="p">,</span> <span class="n">minHeight</span> <span class="o">+</span> <span class="n">t</span> <span class="o">+</span> <span class="n">b</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i'm fine with a fixed size not depending from the text anymore, looks cleaner, why doubling left and right margins tough?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure the correct size, but seems no different with the non-double case.
So i removed the multiplication in newer diff.</pre>
<br />
<p>- Reza</p>
<br />
<p>On August 12th, 2011, 3:01 p.m., Reza Shah wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Reza Shah.</div>
<p style="color: grey;"><i>Updated Aug. 12, 2011, 3:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In current codes, the size of abstracticon will follow the size of widget name.
My diff is to make the size of abstracticon uniform in plasma 'Add Widgets' dialog,
by making the widget name into 2 lines and elided the text.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested against master</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/plasmagenericshell/abstracticon.cpp <span style="color: grey">(0fbdb9e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102305/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>