Review Request: Frame applet should give valid message when dropped folder doesn't have any images

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5362/#review7637
-----------------------------------------------------------

Ship it!


One small issue with i18n context left, otherwise it's good to go in (from my point of view, better wait for annma to mark  it as ship it as well).


trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp
<http://svn.reviewboard.kde.org/r/5362/#comment7791>

    i18n context should be more useful.


- Sebastian


On 2010-09-16 03:54:44, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5362/
> -----------------------------------------------------------
> 
> (Updated 2010-09-16 03:54:44)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This diff will give the user meaningful message when a folder is dropped to the frame applet and if it doesn't contain image(s).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 
> 
> Diff: http://svn.reviewboard.kde.org/r/5362/diff
> 
> 
> Testing
> -------
> 
> This has been tested. 
> 
> 
> Thanks,
> 
> Sujith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100916/9e27af88/attachment.htm