Review Request: Frame applet should give valid message when dropped folder doesn't have any images

[Sujith H]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5362/
-----------------------------------------------------------

(Updated 2010-09-16 03:54:44.933376)


Review request for Plasma.


Changes
-------

Updated the patch with the comments from Anne-Marie and Sebastian. Only missing part in the patch is regarding the arrows that remain even after the slideshow and even if the dropped folder doesn't contain images.


Summary
-------

This diff will give the user meaningful message when a folder is dropped to the frame applet and if it doesn't contain image(s).


Diffs (updated)
-----

  trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 
  trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 
  trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 
  trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 

Diff: http://svn.reviewboard.kde.org/r/5362/diff


Testing
-------

This has been tested. 


Thanks,

Sujith

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100916/26ba9bb0/attachment-0001.htm