Review Request: Frame applet should give valid message when dropped folder doesn't have any images

[Anne-Marie Mahfouf]

> On 2010-09-16 11:20:34, Sebastian Kügler wrote:
> > trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp, line 88
> > <http://svn.reviewboard.kde.org/r/5362/diff/4/?file=36015#file36015line88>
> >
> >     i18n context should be more useful.

I agree with Sebas, ship it and thanks for looking in this issue!
As for the context help for translators, maybe we can put i18nc("Text written on default picture", "Dropped folder is empty. Please drop a folder with image(s)");


- Anne-Marie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5362/#review7637
-----------------------------------------------------------


On 2010-09-16 03:54:44, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5362/
> -----------------------------------------------------------
> 
> (Updated 2010-09-16 03:54:44)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This diff will give the user meaningful message when a folder is dropped to the frame applet and if it doesn't contain image(s).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 
>   trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 
> 
> Diff: http://svn.reviewboard.kde.org/r/5362/diff
> 
> 
> Testing
> -------
> 
> This has been tested. 
> 
> 
> Thanks,
> 
> Sujith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100916/61bbcf5c/attachment.htm