Review Request: Launchersupport in libtaskmanager - final implementation

[Marco Martin]

> On 2010-11-07 18:07:13, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp, line 316
> > <http://svn.reviewboard.kde.org/r/5785/diff/1/?file=40721#file40721line316>
> >
> >     the fact that his can fail hints that this is a feature in the wrong place.
> >     
> >     if it is decided that this context menu should be kept (and i'm not yet convinced it should be), it should _only_ be shown for entries for which a launcher can be created in the first place.
> 
> Anton Kreuzkamp wrote:
>     I thought of it but I didn't know how to check wether it is possible.
>     If you tell me how to do it, I will change it, of course.
> 
> Marco Martin wrote:
>     when the task menu emits aboutToshow() you do the check with the sycoca query and add the entry if needed

with this change for me would be ok to go in.
Aaron, can you just give an ack or a stop before the freeze?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5785/#review8541
-----------------------------------------------------------


On 2010-11-09 20:17:52, Anton Kreuzkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5785/
> -----------------------------------------------------------
> 
> (Updated 2010-11-09 20:17:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is the final implementation of the launchersupport for libtaskmanager. Many parts of the initial implementation has been changed but now everything works as it should.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/desktopsortingstrategy.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions_p.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1193833 
>   trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h 1193833 
> 
> Diff: http://svn.reviewboard.kde.org/r/5785/diff
> 
> 
> Testing
> -------
> 
> Tested and everything worked fine.
> 
> 
> Thanks,
> 
> Anton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101110/bedac96e/attachment.htm