<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5785/">http://svn.reviewboard.kde.org/r/5785/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 7th, 2010, 6:07 p.m., <b>Aaron Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5785/diff/1/?file=40721#file40721line316" style="color: black; font-weight: bold; text-decoration: underline;">trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ToggleLauncherActionImpl::toggleLauncher()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">316</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">groupingStrategy</span><span class="o">-></span><span class="n">toggleLauncherSettingForItem</span><span class="p">(</span><span class="n">abstractItem</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the fact that his can fail hints that this is a feature in the wrong place.
if it is decided that this context menu should be kept (and i'm not yet convinced it should be), it should _only_ be shown for entries for which a launcher can be created in the first place.</pre>
</blockquote>
<p>On November 8th, 2010, 3:34 p.m., <b>Anton Kreuzkamp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I thought of it but I didn't know how to check wether it is possible.
If you tell me how to do it, I will change it, of course.</pre>
</blockquote>
<p>On November 10th, 2010, 10:30 p.m., <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">when the task menu emits aboutToshow() you do the check with the sycoca query and add the entry if needed</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">with this change for me would be ok to go in.
Aaron, can you just give an ack or a stop before the freeze?</pre>
<br />
<p>- Marco</p>
<br />
<p>On November 9th, 2010, 8:17 p.m., Anton Kreuzkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Anton Kreuzkamp.</div>
<p style="color: grey;"><i>Updated 2010-11-09 20:17:52</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the final implementation of the launchersupport for libtaskmanager. Many parts of the initial implementation has been changed but now everything works as it should.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested and everything worked fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/desktopsortingstrategy.cpp <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.h <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions_p.h <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h <span style="color: grey">(1193833)</span></li>
<li>trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h <span style="color: grey">(1193833)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5785/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>