Review Request: Launchersupport in libtaskmanager - final implementation

[Anton Kreuzkamp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5785/
-----------------------------------------------------------

(Updated 2010-11-09 20:17:52.753948)


Review request for Plasma.


Changes
-------

- renamed bool hasFittingLauncher to LauncherItem *findLauncher
- addLauncher returns now a reference to the existing launcher if there is already one
- launchers now get added to all existing rootGroups


Summary
-------

This is the final implementation of the launchersupport for libtaskmanager. Many parts of the initial implementation has been changed but now everything works as it should.


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.cpp 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupingstrategy.h 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/alphasortingstrategy.cpp 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/desktopsortingstrategy.cpp 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.h 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions_p.h 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1193833 
  trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h 1193833 

Diff: http://svn.reviewboard.kde.org/r/5785/diff


Testing
-------

Tested and everything worked fine.


Thanks,

Anton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20101109/bbd8bcf3/attachment-0001.htm