Review Request: Patch to use the data engine for status notifier items

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3265/#review4533
-----------------------------------------------------------


what is the status of this thing?
is the current one meant to be the final or still needs something?

- Marco


On 2010-03-14 17:58:45, Matthieu Gallien wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3265/
> -----------------------------------------------------------
> 
> (Updated 2010-03-14 17:58:45)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Preliminary patch to use the data engine for status notifier items instead of directly the dbus protocol.
> This patch is only a preliminary version to get some early feedback. More work is actually needed.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.h 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.h 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.cpp 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/CMakeLists.txt 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.desktop 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.h 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.cpp 1102568 
> 
> Diff: http://reviewboard.kde.org/r/3265/diff
> 
> 
> Testing
> -------
> 
> Kinda works. Tested in a kde 4.4 session. Even if the port is not complete, the applet is till functionnal.
> 
> 
> Thanks,
> 
> Matthieu
> 
>