Review Request: Patch to use the data engine for status notifier items

[Matthieu Gallien]

> On 2010-03-17 12:13:33, Marco Martin wrote:
> > what is the status of this thing?
> > is the current one meant to be the final or still needs something?

Hello,
It is not final. It is buggy. The icons are not showing up for item like KMix. It is showing up for nepomuk only after Nepomuk starts an analysis of my system.

Sorry for the dealy, I was too busy the last days to debug this. I will try to work on it this evening and will keep you updated.


- Matthieu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3265/#review4533
-----------------------------------------------------------


On 2010-03-14 17:58:45, Matthieu Gallien wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3265/
> -----------------------------------------------------------
> 
> (Updated 2010-03-14 17:58:45)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Preliminary patch to use the data engine for status notifier items instead of directly the dbus protocol.
> This patch is only a preliminary version to get some early feedback. More work is actually needed.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.h 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.h 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.cpp 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/CMakeLists.txt 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.desktop 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.h 1102568 
>   /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.cpp 1102568 
> 
> Diff: http://reviewboard.kde.org/r/3265/diff
> 
> 
> Testing
> -------
> 
> Kinda works. Tested in a kde 4.4 session. Even if the port is not complete, the applet is till functionnal.
> 
> 
> Thanks,
> 
> Matthieu
> 
>