Review Request: Patch to use the data engine for status notifier items

[Matthieu Gallien]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3265/
-----------------------------------------------------------

(Updated 2010-03-14 17:58:45.678252)


Review request for Plasma.


Changes
-------

First version (not yet based on the modification from agateau) that uses also the data engine for the data and use the service when there is action to be triggered.
Everything works for me apart from the main icons showing only for nepomuk.


Summary
-------

Preliminary patch to use the data engine for status notifier items instead of directly the dbus protocol.
This patch is only a preliminary version to get some early feedback. More work is actually needed.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.h 1102568 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtrayprotocol.cpp 1102568 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h 1102568 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp 1102568 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.h 1102568 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraywidget.cpp 1102568 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/CMakeLists.txt 1102568 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.desktop 1102568 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.h 1102568 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/systemtray/statusnotifierwatcher/statusnotifierwatcher.cpp 1102568 

Diff: http://reviewboard.kde.org/r/3265/diff


Testing
-------

Kinda works. Tested in a kde 4.4 session. Even if the port is not complete, the applet is till functionnal.


Thanks,

Matthieu