Review Request: new KWin effect: Dashboard

[Andreas Demmer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4332/
-----------------------------------------------------------

(Updated 2010-06-29 19:29:38.209000)


Review request for kwin and Plasma.


Changes
-------

- Atom name updated
- Plasma dashboard now sets own window class
- KWin now detects dashboard by its window class (no more hacks)
- removed magic number for blur effect, moved to kwineffects and changed in blur effect, too
- call reconfigure() in effect CTOR instead of duplicating code
- implemented DTOR
- brightness/saturation values are now handled as percentage
- fixed blur region
- removed german translation in .desktop files


Summary
-------

This patch adds a new KWin effect that allows to modify the appearance of the Plasma dashboard. It has a KCM configuration dialog where you can adjust brightness, saturation and blur of the dashboard background. Blur depends on the loaded blur plugin.

I also patched the Plasma dashboard to recognize the loaded effect: If the effect is loaded, the dashboard draws its background fully translucent. In order for the Dashboard to recognize wether the effect is loaded, I added support for the effect in Plasma::WindowEffects from kdelibs.

The dashboard detection in the effect itself is hackish right now. As soon as Plasma adds a proper class to the dashboard window, I will replace the hack with a class-check.


This addresses bugs dashboard, detection and hackish.
    https://bugs.kde.org/show_bug.cgi?id=dashboard
    https://bugs.kde.org/show_bug.cgi?id=detection
    https://bugs.kde.org/show_bug.cgi?id=hackish


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt 1144343 
  trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp 1144343 
  trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp 1144343 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui PRE-CREATION 
  trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h 1144343 
  trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp 1144343 
  trunk/KDE/kdelibs/plasma/windoweffects.h 1144345 
  trunk/KDE/kdelibs/plasma/windoweffects.cpp 1144345 

Diff: http://reviewboard.kde.org/r/4332/diff


Testing
-------

Code compiles, plugin loads, plugin configuration dialog is registered in KCM Workspace module under "all effects". If the plugin is enabled, its settings apply to the dashboard.


Screenshots
-----------

configuration dialog
  http://reviewboard.kde.org/r/4332/s/434/
dashboard with modified background
  http://reviewboard.kde.org/r/4332/s/435/


Thanks,

Andreas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20100629/7432839f/attachment.htm