<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4332/">http://reviewboard.kde.org/r/4332/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Andreas Demmer.</div>
<p style="color: grey;"><i>Updated 2010-06-29 19:29:38.209000</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">- Atom name updated
- Plasma dashboard now sets own window class
- KWin now detects dashboard by its window class (no more hacks)
- removed magic number for blur effect, moved to kwineffects and changed in blur effect, too
- call reconfigure() in effect CTOR instead of duplicating code
- implemented DTOR
- brightness/saturation values are now handled as percentage
- fixed blur region
- removed german translation in .desktop files</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">This patch adds a new KWin effect that allows to modify the appearance of the Plasma dashboard. It has a KCM configuration dialog where you can adjust brightness, saturation and blur of the dashboard background. Blur depends on the loaded blur plugin.
I also patched the Plasma dashboard to recognize the loaded effect: If the effect is loaded, the dashboard draws its background fully translucent. In order for the Dashboard to recognize wether the effect is loaded, I added support for the effect in Plasma::WindowEffects from kdelibs.
The dashboard detection in the effect itself is hackish right now. As soon as Plasma adds a proper class to the dashboard window, I will replace the hack with a class-check.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0;">Code compiles, plugin loads, plugin configuration dialog is registered in KCM Workspace module under "all effects". If the plugin is enabled, its settings apply to the dashboard.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=dashboard">dashboard</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=detection">detection</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=hackish">hackish</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/workspace/kwin/effects/CMakeLists.txt <span style="color: grey">(1144343)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/blur/blur.cpp <span style="color: grey">(1144343)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/configs_builtins.cpp <span style="color: grey">(1144343)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/effects/dashboard/dashboard_config.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/KDE/kdebase/workspace/kwin/lib/kwineffects.h <span style="color: grey">(1144343)</span></li>
<li>trunk/KDE/kdebase/workspace/plasma/desktop/shell/dashboardview.cpp <span style="color: grey">(1144343)</span></li>
<li>trunk/KDE/kdelibs/plasma/windoweffects.h <span style="color: grey">(1144345)</span></li>
<li>trunk/KDE/kdelibs/plasma/windoweffects.cpp <span style="color: grey">(1144345)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4332/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://reviewboard.kde.org/r/4332/s/434/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/06/15/dashboard_config_400x100.jpeg" style="border: 1px black solid;" alt="configuration dialog" /></a>
<a href="http://reviewboard.kde.org/r/4332/s/435/"><img src="http://reviewboard.kde.org/media/uploaded/images/2010/06/15/dashboard_400x100.jpeg" style="border: 1px black solid;" alt="dashboard with modified background" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>